code from gotatun#3
Open
Small-Ku wants to merge 3 commits intoWatfaq:masterfrom
Open
Conversation
12 tasks
Member
|
the original code was just extracted from the cloudflare boring tun and your change seems huge - what does it exactly do could you add a bit context? |
Member
|
and why it's better |
Author
|
this code also just extracted from gotatun by mullvad, which forked from boringtun. actually I just extracted it to help me investigate what Watfaq/clash-rs#958 is happening in a more readable way for me. Just end up seems it is not needed for the bug fix. So, it should not bring much benefits that different from the original code. The changes would be fewer manual lifetime management and the use of zero-copy packet structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nothing fancy, just a approach that totally unrelated to the issue at the end but I did do this when investigating Watfaq/clash-rs#958